Blur fix#73
Open
GleammerRay wants to merge 3 commits into
Open
Conversation
Author
|
Apologies for the force push, I have made these changes about a month ago and forgot that the effect failed build with the latest changes when I was trying to improve it further. I have removed these breaking changes via force push as the pull request was only a couple of minutes old. 🙏 |
|
Worked 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have looked into KDE's original magic lamp effect over at https://github.com/KDE/kwin/blob/1d57c9a5aff148061057af7e608c42c86bac0885/src/plugins/magiclamp/magiclamp.cpp and have introduced a few changes from it into this repo to fix the Blur effect not disappearing (#70).
You don't need to include all the changes for it to work, just the two changes up to and including 8b14c35 (Now animating in prePaintWindow). Apparently prePaintScreen animation now occurs before the blur effect is removed in newer Plasma versions, so prePaintWindow needs to be used.
Thanks a lot for this project, it is a beautiful addition to my Mac-like desktop setup.